the Sim Settlements forums!

Register a free account today to become a member! Once signed in, you'll be able to participate on this site by adding your own topics and posts, as well as connect with other members through your own private inbox!

[109a] Incorrect Commercial assignments/inventory

D

Deleted member 10215

Guest
I'm having a wierd issue that I think I've seen others mention in the past, but want to make sure.
By which I mean, in my current save which was started on version 1.0.9 (actually 1.0.9a, as charactername implies), I have Lily assigned at a Bar, and she's giving her correct "vendor bark" dialog lines, but she's got the "vendor only sells their personal inventory and not the store's" glitch going on. In that same settlement, Alex Powell is assigned at a Martial plot, but he ALSO has what I think are "vendor bark" lines, and talking to him has him offer the dialog option to Barter too (and HE has a full stock of food).

Is this sort of thing still happening to anyone else?

Video evidence:
To view this content we will need your consent to set third party cookies.
For more detailed information, see our cookies page.

(side note: is the Vit-O-Matic that hard to actually aim with when used in 'ranged mode' for everyone, or am I just awful with it?)
 
Last edited by a moderator:
I am still on v1.0.8 and most of my "special" NPCs have various vendor lines and the associated inventory while being assigned to non commercial plots.

As to the Vit-o-matic, if you right-click, it has the "targeting" effect and your shot will home in on them. I have not had issue with "shooting" whoever was in my crosshairs.
 
On my case, sometimes if a settler was assigned to a training plot, they behaved like a vendor of a random commercial plot present in the settlement.
 
Yes and it's quite a bit annoying since it worked perfectly fine in SS1 and loved it in SS1.

This issue can occur with any NPC not just SS2 NPCs
Ye, further inspection showed that one of the "Settlers of the Commonwealth" people in that same settlement (on the other Martial plot at the other end of town) has the same issue, acting as a Bar vendor despite Guard assignment. Both guards are assigned to the same Tosser Training Rec plot, too... hmm.
 
On my current playthrough 1.0.8 Alex Powell is assigned to an Industrial plot and has general store dialogue, barter option, and full inventory. My 2 shops in that settlement, Lily at Winking Molerat and Franklin at Museum of Oddities are working correctly. All other settlement shops and settlers work properly.

This is also happening at Starlight for me. Not sure if that matters
 
On my current playthrough 1.0.8 Alex Powell is assigned to an Industrial plot and has general store dialogue, barter option, and full inventory.
I'm also on v1.0.8. Alex is assigned to an Ag plot. (he is the "Farmer Man") Every time I walk by him, he asks if I need a shave... (female PC...) WTF?

I do not remember these issues happening back in the v1.0.0 betas. I'm not 100%, but I think these issues cropped up after the patch that added vendor barks. I remember one game where Katie would follow me around trying to sell me general goods when she was assigned to an Ag plot.
 
Well I don't know much about fallout in particular but from my experience modding other games - this sounds like an indexing bug.
Many games optimize readouts by indexing tables and if the wrong row is being indexed because of how values are added to that table it could cause this bug.

Just a theory - if sim settlements don't just "reassign" jobs but temporarily "removes" the settler from the settlement and "adds" them back into the settlement to reassign to a new job - this would change their index number - so something is referencing that row number it was previously this would result in the entire chain breaking.

This could have happened by using the method to "Move a settler to a new settlement" instead of a basic reassignment.

Just a theory of course.
 
Yes and it's quite a bit annoying since it worked perfectly fine in SS1 and loved it in SS1.

This issue can occur with any NPC not just SS2 NPCs

I'm also on v1.0.8. Alex is assigned to an Ag plot. (he is the "Farmer Man") Every time I walk by him, he asks if I need a shave... (female PC...) WTF?

I do not remember these issues happening back in the v1.0.0 betas. I'm not 100%, but I think these issues cropped up after the patch that added vendor barks. I remember one game where Katie would follow me around trying to sell me general goods when she was assigned to an Ag plot.
Try upgrading to 1. 0.9a
 
And when you are beta testing additions to an Addon, you do not want to introduce unknowns.

I have a feeling New Game #10 is in the future........
 
Normally that'd be good advice, but as the name of my character in my video at the start of the thread shows, that doesn't fix the issue. (I started naming/renaming my characters with the version of SS2 they were started on, for easier tracking of who has which issue)
Actually naming test characters is a good idea. I need to start doing that.
 
I've never been able to replicate this issue, but it has been reported since Alpha.

To address this, we need to try and do some focused testing to create reproducible steps, we tried during Alpha and never could, so I don't have a lot of suggestions in this regard. My assumption would be that it has to do with off-camera reassignments, as things can get really out of sync when a cell is unloaded (that's probably the cause of a large number of unsolved bugs... one more reminder of why we need an engine overhaul, Bethesda!)

The best I can do is explain how all these systems work, and perhaps that will give someone an idea of how to reproduce reliably.

When a settler is assigned to a shop (vanilla or plot), they are put in a special faction which controls their dialogue. When they are unassigned from that object, they are cleared from that faction (or they are supposed to be).

The factions are WorkshopVendorFactionArmor, WorkshopVendorFactionBar, WorkshopVendorFactionClinic, WorkshopVendorFactionClothing, WorkshopVendorFactionWeapons, and WorkshopVendorFactionMisc. The last one is what we use for all the custom SS2 shop types.

You can use the console command: getinfaction X (where X is the form ID of the faction, screenshot attached with all form IDs) to test if an NPC is in the faction.
1618366114284.png

So far it seems all the reports of this issue, the shop type does, or did exist in the settlement, which is why I think it means something has prevented them from being removed from the factions after being unassigned from that type.

The barks use the factions as well, except for the custom shop type barks, which rely on keywords on the NPCs instead.

We seem to have three different, but related issues: NPCs using barks when they shouldn't, NPCs offering vendor inventory that they shouldn't, and NPCs offering personal inventory for sale.

I would like to solve all issues, but for the sake of reducing complexity, I'd recommend tackling one at a time and treating each as an independent thing.

If you are able to replicate any of them in multiple fresh saves, using the exact same steps, you've found a reproducible set. Post those steps, and tag me, and I'll be able to fix very quickly.
 
Last edited:
@kinggath I just started a new playthrough with 1.0.10b and Jun Long is a bartender and has the armor dialogue it's been this way since level 5, I am level 30 and he still hasn't gotten even better armor at his bar. And when I get the What's good today option it's still armor he sells. Looks like his suit of armor. One full set of leather armor is all he's had since assignment as a bartender. I don't even and never built an armor shop in that settlement and it's the only one with plots currently. (Sanctuary)
Only thing I can think is my bar was built and manned before I unlocked the use of Commercial plots in the story.
 
Last edited:
My problem is I scrapped a settlement and built a new one assigned people around and the old npc that where assigned to stores ( especially medical ) would run their lines like they still worked in stores , even though they work farms now. Maybe the settlers are getting stuck in factions ?
 
I'm going to bump this thread with some more up to date notes on trying to figure this out:

Had it happen on v1.0.14:
Settler in question was a "Generic", had never been assigned to anything else (auto assign is off)
Manual assignment to Settler in question of a vanilla Bed, 1x1 Martial "Checkpoint", and a 2x2 Rec:Training "Tosser Training" that were freshly built and had never had anybody else assigned
Waited in settlement for plots to completely build plus a good 10 minutes of game time
Left settlement for other questing, came back a good 24 hours of gametime later
That "Guard Duty" Settler now had the General Goods Vendor interaction and sale inventory
- a General Goods Store does exist in that settlement, THEY have the Vendor Dialog too but have the "no inventory bug"
 
Did you try the Vit-o-matic? I thought Kinggath said something about adding some code to check NPC assignments in one of the latest patches.
 
Did you try the Vit-o-matic? I thought Kinggath said something about adding some code to check NPC assignments in one of the latest patches.
Just tried that now, did not appear to have any effect except for making the guy go "Oof". Same effect as what it had in the video I posted earlier in this thread months ago.
 
Top