Menu
What's new
By:
Filters
the Sim Settlements forums!

Register a free account today to become a member! Once signed in, you'll be able to participate on this site by adding your own topics and posts, as well as connect with other members through your own private inbox!

Fixed Loss of junk when donating

S

sam_pokemon

New Member
Messages
7
When i donate junk to most settlements it takes all the junk i give it e.g. (10k wood) and dosn't give any of it back as surplus.(dosn't even say there was surplus)

i tried multiple settlements sanctuary to coastal cottage and the same thing (reloading the save after multiple attempts).(also sometimes it didn't register that i even donated anything)

i then thought it was a save issue so i made a new save and ran to sanctuary (the only settlement unlocked scrapped a ton of items and got 1k wood donated that and poof its gone)

current mods i have
(nexus mod manager)
tasty map
spectacle island revamped version 8
place everywhere
manufacturing extended + far harbour addon
legendary modification
key nuker and keyring
increased settler population (30)
replace pack bramins with eyebots
hud framework
bs defence
aloots home plate
advanced settlement power +contraptions

(bethesda,net mod list)
radiant quest markers
unofficial fo4 patch
galaxy news radio
no more fake puddles
weightless junk
holstered weapons by azar
sanctuary bridge fix
visible companion affinity
reduced grass and clutter objects medium
true storms
settlement limits slashed
the beantown interiors project
companion + dogmeat
atomic radio
conveyor belt barriers
clean and smooth Boston airport
sim settlements ted's leaders pack
and all sim settlements official releases (not the helper tho)

(other info high end computer 16gb ram 1080 graphix card i7 7700)

(hope this helps)
 
The excess is supposed to be put back in the workbench. Are you finding this isn't happening?
 
I rewrote the donation code for the next patch. It should be faster and less error prone!
 
kinggath said:
I rewrote the donation code for the next patch. It should be faster and less error prone!
Click to expand...
i downloaded the update today and ran the fix sim settlement fix files wizard and sadly it didn't fix the bug i will test a bit more but otherwise i am gonna disable all mods clean save and try if that dosn't work i will backup fallout 4 and re download all of fallout 4 and try the same thing on a brand new save with just sim settlements ill post my results with my findings hope we can get this sorted :D

EDIT: disabling all mods didn't work clean saving out simsettlements didnt work time to redownload all of fallout 4 and try on a new save with just sim settlements if that dosnt work we have a pesky bug on our hands
 
Last edited:
I donate tons of of stuff hoping excess make its it to work bench missing several salvage beacons but at another settlement went to grab more food and nades none in work bench went to idsk locker and I found my missing salvage beacons 7 of them ended up in there along with stuff I put in other workbenchs at other settlements (all of which had idks locations guess idks is grabing stuff from bench
 
re downloaded fallout 4 and only sim settlements and rise of the commonwelth removed all old prefrences from documents folder and removed game entirely sadly the bug is still present @kinggath

i want to say i only gave myself level 175 via console and 2 circuitry rushed museum of freedom made cogsworth leader of sanctuary bypassed red rocket and scapped plenty of things at sanctuary made city planers desk got level 0 then donated 900 wood all gone none put back into the workbench as surplus :(
 
sam_pokemon said:
re downloaded fallout 4 and only sim settlements and rise of the commonwelth removed all old prefrences from documents folder and removed game entirely sadly the bug is still present @kinggath

i want to say i only gave myself level 175 via console and 2 circuitry rushed museum of freedom made cogsworth leader of sanctuary bypassed red rocket and scapped plenty of things at sanctuary made city planers desk got level 0 then donated 900 wood all gone none put back into the workbench as surplus :(
Click to expand...
yeah it sucks I put more junk than that into donation box(via salvage beacon) not realizing that the city was not upgrading

I am at a point I can not even play right now cause i keep ctd still working on fixing the issue. DAMN win10 updates currently almost done hopefully I ended up deleting almost 80 gig of win10 recovery/update files. win1o kept down loading that stupid win10 upgrade assistance and never would never do anything. except gobble up my OS drive space. I had less then a gig left
 
Last edited:
YES I AM BACK INTO THE GAME. Got rid of the win10 feature update and it is not reinstalling (currently knock on wood) and freed up 59 gig of my os drive space
 
Ahh ok - looking at my code that makes sense. All of the extra scrap will be applied to the next level. The only thing I need to add is a way for them to return all of the extra after the settlement reaches level 3.

EDIT: Actually - that won't work because the exact stored scrap isn't recorded. I'll look into some method of giving back everything past 100% for the current level. But anything extra you donated is applied to the next level. So as soon as you upgrade, you'll find the percentage to the following level will be up already.
 
just a idea
what about a overflow box where all the extra stuff goes to then you could do it like the food and water but instead of the extra scrap going back into your inventory it goes into the overflow box, as well as. any extra food and water. You would just have to retrieve the the overflow items from the overflow flow to donate them again after the upgrade. The overflow box can be part of the city desk not something separate. Of course the settlers might take stuff from the overflow box,
 
kinggath said:
Ahh ok - looking at my code that makes sense. All of the extra scrap will be applied to the next level. The only thing I need to add is a way for them to return all of the extra after the settlement reaches level 3.

EDIT: Actually - that won't work because the exact stored scrap isn't recorded. I'll look into some method of giving back everything past 100% for the current level. But anything extra you donated is applied to the next level. So as soon as you upgrade, you'll find the percentage to the following level will be up already.
Click to expand...

isn't this researching not working as intended ?
 
Originally I was tossing in scrap and getting to 100% which I think was just wasted much of the time. I just add scrap more slowly now to avoid doing that instead of just tossing it all at once into the donation and assuming I'll get the extra back somewhere.
 
The current bug is dropping in more than one type of scrap at a time can result in only the first type dropped in being counted.
 
I think there's a problem with delays in function SimParent.ProcessDonatedItem when counting scrap. In this line:
Code: 
AutoBuildParent.WorkshopDataStore[iWorkshopID].iCollectedScrapValue = AutoBuildParent.WorkshopDataStore[iWorkshopID].iCollectedScrapValue + CityPlanManager.CalculateTotalScrapValue(junkChecker)

Function CityPlanManager.CalculateTotalScrapValue is calculated for a long time (2 - 6 seconds on my PC). After 2 - 6 seconds, the data iCollectedScrapValue placed on the stack is outdated, because up to 10 threads are running in parallel. We add ScrapValue to the outdated iCollectedScrapValue and write the wrong value back. As a result, donation statistics growth is very slow. Although a lot of scrap were donated.

I propose to change:
Code: 
Int Temp = CityPlanManager.CalculateTotalScrapValue(junkChecker)
; 2 - 6 seconds passed here, we need actual iCollectedScrapValue to increment and write back
AutoBuildParent.WorkshopDataStore[iWorkshopID].iCollectedScrapValue = AutoBuildParent.WorkshopDataStore[iWorkshopID].iCollectedScrapValue + Temp
 
You must log in or register to reply here.
Top